Skip to content

Refactor command logging a tad #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2025
Merged

Refactor command logging a tad #1547

merged 4 commits into from
Jul 14, 2025

Conversation

Mpdreamz
Copy link
Member

  • centralize log assignment
  • Normalize ILoggerFactory arguments

@Mpdreamz Mpdreamz requested a review from a team as a code owner July 10, 2025 15:18
@Mpdreamz Mpdreamz added the chore label Jul 10, 2025
@Mpdreamz Mpdreamz self-assigned this Jul 10, 2025
@Mpdreamz Mpdreamz added the chore label Jul 10, 2025
@Mpdreamz Mpdreamz changed the title refactor/commands Refactor command logging a tad Jul 10, 2025
reakaleek
reakaleek approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is failing. But generally LGTM.

@Mpdreamz Mpdreamz merged commit 701f2ab into main Jul 14, 2025
17 checks passed
@Mpdreamz Mpdreamz deleted the refactor/commands branch July 14, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

Assignees

@Mpdreamz Mpdreamz

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @reakaleek